Skip to content

fix(webapp): require explicit native button types - #4692

Merged
carderne merged 1 commit into
refactor/webapp-redundant-fragments-tri-13381from
fix/webapp-explicit-button-types-tri-13381
Aug 19, 2026
Merged

fix(webapp): require explicit native button types#4692
carderne merged 1 commit into
refactor/webapp-redundant-fragments-tri-13381from
fix/webapp-explicit-button-types-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add explicit types to native dashboard buttons and enforce react/button-has-type.

This prevents action buttons from accidentally submitting a surrounding form. Shared button primitives retain their caller-selected submit and reset semantics with documented lint exceptions.

Base: #4691

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d7f329d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 980c2ffd-8276-4fc2-a055-7578be12fe28

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-explicit-button-types-tri-13381 branch from 939d509 to 6232bbc Compare August 19, 2026 11:48
@carderne
carderne force-pushed the fix/webapp-explicit-button-types-tri-13381 branch from 6232bbc to f9f586b Compare August 19, 2026 11:49
@carderne
carderne force-pushed the fix/webapp-explicit-button-types-tri-13381 branch from f9f586b to d7f329d Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@d7f329d

trigger.dev

npm i https://pkg.pr.new/trigger.dev@d7f329d

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@d7f329d

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@d7f329d

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@d7f329d

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@d7f329d

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@d7f329d

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@d7f329d

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@d7f329d

commit: d7f329d

@carderne
carderne merged commit dda9504 into main Aug 19, 2026
39 checks passed
@carderne
carderne deleted the fix/webapp-explicit-button-types-tri-13381 branch August 19, 2026 15:36
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Enable foundational JSX accessibility checks for image text alternatives
and valid ARIA roles.

The avatar color picker now has an explicit accessible name and
decorative image alternative. Dashboard chat styling props no longer
reuse the reserved DOM `role` name.

Base: [#4692](#4692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants