Skip to content

fix(webapp): enforce associated form labels - #4695

Merged
carderne merged 1 commit into
fix/webapp-admin-form-labels-tri-13381from
fix/webapp-remaining-form-labels-tri-13381
Aug 19, 2026
Merged

fix(webapp): enforce associated form labels#4695
carderne merged 1 commit into
fix/webapp-admin-form-labels-tri-13381from
fix/webapp-remaining-form-labels-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Finish associating dashboard form labels with their controls and enforce jsx-a11y/label-has-associated-control.

Repeated data store dialogs use unique generated IDs, story controls and notification filters have explicit associations, and display-only status text no longer uses label elements.

Base: #4694

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d03ca8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3cadc42a-9ae0-483e-b156-87110470f7c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-remaining-form-labels-tri-13381 branch from f74d479 to 3a8a499 Compare August 19, 2026 11:48
@carderne
carderne force-pushed the fix/webapp-remaining-form-labels-tri-13381 branch from 3a8a499 to 92d2359 Compare August 19, 2026 11:49
@carderne
carderne force-pushed the fix/webapp-remaining-form-labels-tri-13381 branch from 92d2359 to d03ca8c Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@d03ca8c

trigger.dev

npm i https://pkg.pr.new/trigger.dev@d03ca8c

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@d03ca8c

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@d03ca8c

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@d03ca8c

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@d03ca8c

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@d03ca8c

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@d03ca8c

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@d03ca8c

commit: d03ca8c

@carderne
carderne merged commit 3a091eb into main Aug 19, 2026
39 checks passed
@carderne
carderne deleted the fix/webapp-remaining-form-labels-tri-13381 branch August 19, 2026 15:36
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Require accessible names for dashboard controls.

Filter menu action items and chart color controls now expose explicit
names. The chart legend action uses a native button, while lint depth
and spacer-cell configuration match the rendered control structure.

Base: [#4695](#4695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants