Proxy TrueFoundry skill catalog and return 424 on skill writes - #631
Open
bhaveshpatel640 wants to merge 21 commits into
Open
Proxy TrueFoundry skill catalog and return 424 on skill writes#631bhaveshpatel640 wants to merge 21 commits into
bhaveshpatel640 wants to merge 21 commits into
Conversation
bhaveshpatel640
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 8, 2026 11:11
🦋 Changeset detectedLatest commit: 6142574 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 8, 2026 11:28
ffb81da to
a313d05
Compare
bhaveshpatel640
requested review from
govindavashishtha,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
September 8, 2026 11:28
bhaveshpatel640
force-pushed
the
AGE-2127
branch
2 times, most recently
from
September 8, 2026 11:43
0094216 to
906bb19
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 8, 2026 18:41
7145b62 to
d71ee8f
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
2 times, most recently
from
September 8, 2026 19:03
2348787 to
818bc2d
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 8, 2026 19:24
fca26ab to
750e1e0
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 14:51
4863708 to
022a9ee
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 15:25
4fc05b4 to
2e2b6ae
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 15:41
0728b36 to
1ff5762
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 15:44
e9ce223 to
ae85fd3
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 16:04
69ceaed to
ef8b4f6
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 16:31
2a2e8ca to
bac89cb
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 16:41
d14304e to
2badcab
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 16:41
2badcab to
62ef0f5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4ca386a. Configure here.
bhaveshpatel640
marked this pull request as draft
September 9, 2026 20:28
bhaveshpatel640
force-pushed
the
AGE-2127
branch
3 times, most recently
from
September 9, 2026 20:59
97848a5 to
2cbe5ad
Compare
bhaveshpatel640
force-pushed
the
AGE-2127
branch
from
September 9, 2026 21:06
2cbe5ad to
6142574
Compare
bhaveshpatel640
marked this pull request as ready for review
September 9, 2026 21:15
bhaveshpatel640
added this pull request to stack #662
September 9, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
TrueFoundry mode proxies the SFY skill catalog with the caller token. Settings skill writes return 424.
Closes AGE-2127
Changes
GET /api/v1/skillsandGET /api/v1/skills/{skill_id}/versionsread SFY (caller JWT)id,fqn(latest),ml_repo_name,name,description; versions:version(number) +fqnHow was this tested?
Unit tests:
mapSfyAgentSkills,TrueFoundrySkillStore, skills API.Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Changes skill validation, turn-time resolution, and external SFY calls with caller/agent tokens; misconfiguration could break agent saves or skill mounting in TrueFoundry mode.
Overview
Adds TrueFoundry-managed skills: in TrueFoundry mode,
GET /api/v1/skillsandGET /api/v1/skills/versionsare served from ServiceFoundry via a per-requestTrueFoundrySkillStore(same token/vend pattern as models and MCP). Settings create/upsert skill calls return 424 when the catalog is externally managed.Schema/API:
SkillManifestis a discriminatedgit|truefoundryunion; chatAvailableSkillcan include metadata (display_name,repository_name,version). AgentSpec skills accept opaque FQN-style names, optionalpreload, and are capped at 50; git-backed stores rejectpreload.Runtime: Skill storage is wired through
resolveSkillStore(SQLite/Postgres git skills vs SFY). Agent save/turn paths usevalidateAgentSkills(git name lookup or SFY resolve). OpenAPI andtrueforge-sdkaddlistVersionsand 424 handling on settings skills.UI: The builder maps catalog
id(attach key) to wirename, surfaces display labels, and round-tripspreloadon session/agent admission.Reviewed by Cursor Bugbot for commit 6142574. Bugbot is set up for automated code reviews on this repo. Configure here.