trunk-merge/pr-1196/ac3ad0eb-08e7-417e-a9be-2acd690ca7d7 - #1200
Closed
trunk-io[bot] wants to merge 2 commits into
Closed
trunk-io[bot] wants to merge 2 commits into
trunk-io[bot] wants to merge 2 commits into
Conversation
…inks The report table's per-test links now use the ADR-0019 GUID — a UUIDv8 hash of `(test_collection_id, repo_id, test_case_id)` — addressing the canonical `collections/<short_id>/tests/<guid>` page directly instead of the `/t/<id>` short link the webapp has to resolve a repo for and redirect. The two server-owned legs of the tuple come from `createBundleUpload`, which now returns `repoId` and `testCollectionId` (trunk-io/trunk#33761). Both are `Option` with `serde(default)`: a server predating that PR sends neither, `testCollectionId` is absent under maintenance mode and for orgs with the receipt-inserts flag off, and the CLI must keep working against all of them. Every way the GUID can be unavailable funnels through one decision point in `url_for_test_case` and falls back to today's link: - no collection short id, or links hidden - the server returned no ids - `test_case.id` is not a UUID — a report-supplied id passes through verbatim (RSpec emits `trunk:<id>-<location>`), and hashing one would mint a well-formed GUID that addresses nothing `gen_test_case_guid` is the same compiled `context` crate ingest runs, so there is no second implementation of the frozen hash. The URL test pins ADR-0019's first golden vector rather than recomputing the hash, so a drift in either the contract or the URL shape fails the build. The pre-upload `log_failure` lane still prints the short link: it runs before `createBundleUpload`, so the ids do not exist yet. Hoisting that call is the follow-up. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
==========================================
+ Coverage 83.63% 83.92% +0.29%
==========================================
Files 74 74
Lines 17573 17652 +79
==========================================
+ Hits 14697 14815 +118
+ Misses 2876 2837 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
trunk-io
Bot
deleted the
trunk-merge/pr-1196/ac3ad0eb-08e7-417e-a9be-2acd690ca7d7
branch
September 14, 2026 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA ccaad7f8b75339cdf8bed42459ff69a54e637da5.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1196.