trunk-merge/pr-1201/484c16fc-ae39-4516-b8bc-59ef177e6cc0 - #1202
Closed
trunk-io[bot] wants to merge 4 commits into
Closed
trunk-io[bot] wants to merge 4 commits into
trunk-io[bot] wants to merge 4 commits into
Conversation
The argument took literal filenames, so a repository with more than one test target had to spell out every file `swift test --xunit-output` wrote, and a pattern reached `File::open` verbatim and failed. `--junit-paths` has always globbed, so the same spelling meant different things depending on which argument carried it. Expansion now goes through the junit path's own, which also brings its dedupe: matches are keyed by canonical path, so a file two patterns both match -- or one reached through a symlink as well as directly -- is parsed once instead of uploading every test it holds twice. `collect_files_per_glob` took junit wrappers to read one field off each, so it now takes the globs themselves and `expand_globs` exposes the flattened result. One implementation, rather than a second one that drifts. Two consequences worth knowing. A relative value now resolves against the repo root rather than the working directory, which is what `--junit-paths` has always done and only differs when the uploader runs outside the repo. And a value naming a file that is not there no longer fails on open -- it matches nothing, exactly as a junit glob does, leaving the existing empty-results check to decide whether that is an error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
They only exercise `FileSetBuilder::expand_globs`, which is public, so nothing about them needs to sit inside the module. As an integration test they exercise the crate the way its callers do and cannot quietly come to depend on a private detail. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Say what the code does and drop the rest: which argument historically expanded differently, why a test needs no toolchain, what an uploaded duplicate would look like downstream. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
+ Coverage 83.70% 83.93% +0.22%
==========================================
Files 74 74
Lines 17652 17667 +15
==========================================
+ Hits 14776 14828 +52
+ Misses 2876 2839 -37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trunk-io
Bot
deleted the
trunk-merge/pr-1201/484c16fc-ae39-4516-b8bc-59ef177e6cc0
branch
September 16, 2026 17:20
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 3da768f9bc2849059eb08551171b9fd2976902a0.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1201.