Skip to content

feat: add HOL Guard tool - #1163

Merged
trunk-io[bot] merged 16 commits into
trunk-io:mainfrom
kantorcodes:add-hol-guard
Sep 16, 2026
Merged

trunk-io[bot] merged 16 commits into
trunk-io:mainfrom
kantorcodes:add-hol-guard

Conversation

@kantorcodes

@kantorcodes kantorcodes commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds HOL Guard as a standalone Trunk tool backed by the stable hol-guard PyPI package.

  • exposes the hol-guard shim through Trunk's default plugin source
  • pins the validated known_good_version to 3.0.166
  • adds a hol-guard --version semver health check
  • adds the repository-native toolInstallTest

This follows the current tools/ contribution pattern for Python runtime packages. HOL Guard v3.0.166 is the validated release used by this contribution.

Validation

  • manifest/test structure mirrors existing Trunk Python tools and hyphenated tool naming
  • plugin.yaml and toolInstallTest both pin 3.0.166
  • the earlier merge-queue macOS failure was on 3.0.18, where a base LiteLLM dependency fell back to a Rust build under Python 3.14; 3.0.166 no longer includes LiteLLM/Cisco scanner in its base dependencies

I could not run the full local trunk check in the connected execution environment, so I am not claiming that as passed; the repository-native install test is included for CI.

Affiliation: I maintain HOL Guard / Hashgraph Online. AI assistance was used to prepare this focused contribution and the release refresh.

@trunk-io

trunk-io Bot commented Aug 25, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

Copy link
Copy Markdown
Contributor Author

/trunk merge

@kantorcodes

Copy link
Copy Markdown
Contributor Author

/trunk merge

@trunk-io

trunk-io Bot commented Aug 26, 2026

Copy link
Copy Markdown

An error occurred while submitting your PR to the queue: Only users that are a part of this repo's Trunk organization or have write permissions to the repo can submit a PR to the queue

@kantorcodes

Copy link
Copy Markdown
Contributor Author

All required changes are in and the PR is still mergeable. The queue command now reports that only a repo member or someone with write access can submit it. Could a maintainer add #1163 to the merge queue when convenient? I’ll handle any requested changes right away.

@EliSchleifer EliSchleifer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Copy link
Copy Markdown
Contributor Author

The prior merge-queue failure was the macOS job installing 3.0.18: litellm fell back to a Rust build under Python 3.14 and the runner had no cc. The current branch pins 3.0.166, which no longer pulls cisco-ai-skill-scanner / litellm as base dependencies, so that specific failure should be gone. If you can requeue this head, I can handle anything else that surfaces.

@trunk-io
trunk-io Bot merged commit 8318561 into trunk-io:main Sep 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants