Conversation
…anual run (CS-715) (#3376) * fix(integration-platform): classify code-based checks statically on manual run (CS-715) The manual "run a check" endpoint decided whether a run was dynamic (held as an 'inconclusive' result for the self-heal agent, and hidden from the run history) versus static (shown as failed/pass) by checking only whether an active DynamicIntegration row existed for the provider slug. Several providers ship a code-based manifest AND an active DynamicIntegration row of the same slug for their extra DB-backed checks. A code manifest always wins in the registry, so the check that actually runs is the code one and must be classified statically. Keying `isDynamic` off the DB row alone marked those code-check runs 'inconclusive', so their results were withheld from the manual run while the scheduled and server-run paths (which guard on the code manifest) kept showing them correctly. Add a registry helper `isCodeManifest` and gate the manual-run `isDynamic` on it, mirroring the scheduled/server-run paths: a provider with a code manifest is never dynamic; only a provider with no code manifest is. Add unit tests covering the bundled manifests, the mixed code+dynamic providers, and the dynamic-only case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CRPjA4fQxdXuELyfTjYF8b * fix(integration-platform): guard self-heal re-run classification for code-based checks (CS-715) Extend the isCodeManifest guard from the manual run-check path to the self-heal agent's re-run (rerunAndPersistCheck). A code-based provider that also has a dynamic integration row of the same slug (github/vercel/aikido/rippling) was re-held as 'inconclusive' on re-run — and since the agent cannot patch a code check, it stayed hidden in a loop. It is now classified statically and its real result is shown. Dynamic integrations are unaffected (isCodeManifest is false for them, so the dynamic lookup runs exactly as before). Tests: - self-heal re-run reveals a code-based check as 'failed' (not re-held), even when a dynamic row shares the slug. - manual run-check treats a code-based provider as static under the same condition; adds the isCodeManifest mock the controller spec now requires. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CRPjA4fQxdXuELyfTjYF8b --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.99.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Fixes hidden results when running checks for providers that have both a code manifest and an active dynamic integration. Code-based checks are now treated as static in manual runs and self-heal re-runs, so real failures are shown instead of held as “inconclusive” (CS-715).
isCodeManifestto the@trycompai/integration-platformregistry and exported it.isCodeManifestwhen deciding dynamic vs static; code manifests override dynamic rows with the same slug.github).Written for commit 200b191. Summary will update on new commits.