Closed
Fix: missing COPY for third_party/parquet_format in Dockerfile.all#15
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job "Build All-Formats Image"
Fix: missing COPY for third_party/parquet_format in Dockerfile.all
Jul 20, 2026
Owner
|
Close by ef28145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Build All-Formats Image" CI job was failing because
parquet_types.hwas unavailable at compile time inside the Docker builder stage.Root Cause
CMakeLists.txtaddsthird_party/parquet_formatas a private include directory fortpch_core(providing the Thrift-generatedparquet_types.hconsumed byparquet_footer_merge.cpp), but.docker/Dockerfile.allnever copied that directory into the build context — every otherthird_party/subdirectory was present except this one.Change
Added the missing
COPYinstruction to the builder stage in.docker/Dockerfile.all:COPY third_party/parquet_format third_party/parquet_format