[pull] master from php:master#1097
Merged
Merged
Conversation
Fix a few incorrect socket_set_option() validation error messages.
* PHP-8.5: ext/sockets: Fix socket_set_option() validation error messages (#22772)
make_http_soap_request() looked for the reason phrase with strstr(tmp, " ") even when the first strstr() found no space, which happens for a status line carrying a version but no status code, such as "HTTP/1.1". tmp is NULL there, so strstr() dereferenced it and the client crashed. Only parse the reason phrase when a status code field was present. Closes GH-22761
* PHP-8.4: ext/soap: fix NULL deref on malformed HTTP status line
* PHP-8.5: ext/soap: fix NULL deref on malformed HTTP status line
The no-data case binds an ETH_P_ALL packet socket to lo and asserts that a non-blocking recvfrom() finds nothing, which only holds while no other test puts a frame on loopback. run-tests spawns workers in parallel and the job runs as root, so any concurrent test that talks to localhost makes the socket capture a frame and recvfrom() returns data instead of failing. Observed on LINUX_X32_DEBUG_ZTS: bool(false) where bool(true) was expected. Closes GH-22773
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )