[pull] master from php:master#1098
Merged
Merged
Conversation
php_ftp_dirstream_read() sized the basename copy with MIN(sizeof(ent->d_name), ZSTR_LEN(basename) - 1) and wrote the terminator at [tmp_len - 1]. An empty listing line leaves a basename of length 1, so tmp_len is 0 and the NUL lands one byte before d_name; a slash-only line leaves length 0, so the subtraction underflows to SIZE_MAX and memcpy() reads 4096 bytes past the interned empty string. The same off-by-one truncated entry names that do not end in CRLF. Closes GH-22768
* PHP-8.4: ext/standard: fix out-of-bounds access in the ftp:// directory stream
* PHP-8.5: ext/standard: fix out-of-bounds access in the ftp:// directory stream
RFC: https://wiki.php.net/rfc/partial_function_application_v2 Co-authored-by: Joe Watkins <krakjoe@php.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )