[pull] master from ruby:master#1218
Merged
Merged
Conversation
kill(getpid(), SIGSEGV) can be handled by other threads (as long as they don't block the signal) whereas raise(3) should be implemented as pthread_kill(getpid(), sig). I'm worried mainly about the timer thread handling the signal. We've been seeing CI failures in test_rubyoptions.rb that exercises the SEGV handler via `Process.kill` (which uses kill(2)).
Reset each existing instruction profile and reinstall zjit_* instructions after compiling a non-final version. Do the same for inlined ISEQs so materialized frames can collect fresh profiles. Let interpreter profiling instructions collect the samples and make recompile exits only observe whether the exiting instruction has finished profiling.
This lets us see stack traces for send, ivar fallbacks.
Sometimes we have too many stack slots to fit in one sub operand on ARM. That's fine. We can iteratively subtract instead of doing it all in one instruction.
This is useful for seeing general impact of optimizations. For example, upcoming SSA minimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )