Skip to content

Scan improvements - #4482

Open
je-cook wants to merge 3 commits into
ukaea:mainfrom
je-cook:plot_scan_simplification
Open

Scan improvements#4482
je-cook wants to merge 3 commits into
ukaea:mainfrom
je-cook:plot_scan_simplification

Conversation

@je-cook

@je-cook je-cook commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Description

This is part of #4308 but starting to split out things that can be reviewed now.
This removes a lot of duplication around scans.

Also there scan variable 14 was not accessible before (i have made it so here). Is that wanted?

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 34.75936% with 244 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.28%. Comparing base (83d9f63) to head (33d2db5).

Files with missing lines Patch % Lines
process/core/io/plot/scans.py 12.50% 203 Missing ⚠️
process/core/scan.py 70.92% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4482      +/-   ##
==========================================
+ Coverage   48.67%   49.28%   +0.61%     
==========================================
  Files         151      151              
  Lines       29734    29467     -267     
==========================================
+ Hits        14474    14524      +50     
+ Misses      15260    14943     -317     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants