fix: bump example function-msgraph pins to v0.8.0 - #125
Open
ytsarev wants to merge 1 commit into
Open
Conversation
example/e2e/function.yaml still pinned the v0.8.0-rc2 release candidate, and example/functions.yaml was two releases behind at v0.6.0. Verified against the released package: example/e2e/function.yaml applies to a kind cluster running Crossplane 2.3.3 and reaches Healthy on function-msgraph:v0.8.0 (revision digest c18786ca878a), with the queryInterval and activeAccount e2e scenarios passing. example/functions.yaml keeps its render.crossplane.io/runtime: Development annotation, so its pin is documentation only; the documented render workflow was re-run against a local build to confirm it still works. Leaves function-environment-configs:v0.6.0 untouched. Signed-off-by: Yury Tsarev <yury@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Post-release cleanup of two stale
function-msgraphpackage pins found while running post-release validation of v0.8.0:example/e2e/function.yamlv0.8.0-rc2v0.8.0example/functions.yamlv0.6.0v0.8.0The
e2eone is the release candidate left behind after tagging. Renovate'scrossplanemanager does coverexample/**, but it is unlikely to move a pin off a pre-release version on its own, so this needed a manual bump.function-environment-configs:v0.6.0inexample/functions.yamlis deliberately left alone; it shares thev0.6.0string but is a separate package.How this is covered by tests
No unit tests apply (manifest-only change), so both files were exercised directly against the released artifact.
example/e2e/function.yaml, on kind + Crossplane 2.3.3:Healthy, with the installedFunctionRevision(function-msgraph-c18786ca878a) matching the released image digestsha256:c18786ca878a....status.lastQueryTimestampsfield. Five forced reconciles inside the 2m window left Graph calls flat at 1 whileFunctionSkip/IntervalLimitskips incremented and the timestamp stayed frozen. After the window elapsed, the next reconcile re-queried and the timestamp advanced.accountEnabled: false; theactiveAccount: truecomposition stored only the enabled user, logged the per-user exclusion, and held that across further forced reconciles. Both XRsSYNCED=True READY=True.example/functions.yamlkeeps itsrender.crossplane.io/runtime: Developmentannotation, so its pin is documentation only and is not whatcrossplane renderactually executes. The documented render workflow was re-run through this file against a local build to confirm it still works (3 scenarios, allFunctionSuccess/Success).Separately, all 19
crossplane renderexample scenarios (4 query types x static/status-ref/spec-ref/context-ref, plus the queryInterval fresh/skip and activeAccount cases) were run against the released package with the Development annotation removed. All passed withFunctionSuccess/Successand zero non-Normalresults.I have:
Added or updated unit tests for my change.Manifest-only version bump; validated end-to-end against the released package as described above.