test(e2e): expand Playwright coverage for the theme switcher - #86
Open
lokesh-bruno wants to merge 3 commits into
Open
lokesh-bruno wants to merge 3 commits into
lokesh-bruno wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 1e6f20a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lokesh-bruno
changed the title
sachin-bruno
approved these changes
Sep 22, 2026
Expanded Playwright coverage for the theme switcher in e2e tests.
arpit-bruno
requested changes
Sep 24, 2026
Collaborator
There was a problem hiding this comment.
this one passes even when saving the theme is broken. try commenting out the localStorage.setItem in theme.ts and run the spec and then reload / new tab / explicit light all failed but this stayed green.
Also moving between pages never reloads so the theme is just kept in memory.
| await reopened.goto('/'); | ||
|
|
||
| await expect(reopened.locator('html')).toHaveAttribute('data-theme', 'dark'); | ||
| await expect(reopened.getByTestId('theme-toggle')).toHaveAccessibleName('Switch to light theme'); |
Collaborator
There was a problem hiding this comment.
this skips the page object because it is tied to the first page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref BRU-4604
Description
Adds E2E coverage for the Collection Docs light/dark theme switcher so the chosen theme is applied without a refresh and remembered across reload, navigation, and a new tab.
The coverage includes: