chore: prepare Rust 0.4.3 and Python 6.5.1 releases - #374
Merged
Conversation
Keep the precise bytes-or-text API annotation while making the test suite prove and narrow the return type for compact and pretty output.
Release the XML 1.0 validation fix before the Python wrapper so fast installs can require a compatible published accelerator.
Contributor
Reviewer's GuidePrepares the json2xml-rs 0.4.3 Rust accelerator release and documents the Python/Rust release sequencing while tightening Json2xml.to_xml() test expectations to match the documented pretty vs compact return-type contract. Sequence diagram for Json2xml.to_xml pretty vs compact return typessequenceDiagram
actor User
participant Json2xml
participant dicttoxml_fast
User->>Json2xml: to_xml(pretty)
Json2xml->>dicttoxml_fast: dicttoxml(wrapper, root, attr_type, item_wrap, cdata, list_headers)
alt [pretty=True]
dicttoxml_fast-->>Json2xml: unicode_text
Json2xml-->>User: unicode_text
else [pretty=False]
dicttoxml_fast-->>Json2xml: utf8_bytes
Json2xml-->>User: utf8_bytes
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
isinstance(xmldata, bytes/str)assertions are repeated across many tests; consider extracting a small helper or using parametrized tests to assert type and content together to keep the suite DRY and easier to adjust if the contract changes again.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `isinstance(xmldata, bytes/str)` assertions are repeated across many tests; consider extracting a small helper or using parametrized tests to assert type and content together to keep the suite DRY and easier to adjust if the contract changes again.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 920 920
=========================================
Hits 920 920
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release order
Verification
Summary by Sourcery
Prepare the json2xml-rs 0.4.3 accelerator release and align Python behavior and documentation around Json2xml.to_xml() return types and the Rust-first release flow.
Bug Fixes:
Enhancements:
Build:
Documentation:
Tests:
Chores: