ci: migrate to pnpm/setup - #566
Merged
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow changes are straightforward, YAML structure is valid, and pnpm/setup inputs used (install: false) match the action’s supported interface.
Pull request overview
Updates the repository’s GitHub Actions CI to use pnpm/setup (native pnpm binary) instead of pnpm/action-setup, addressing Windows breakage while keeping the existing install/run flow (via nci / nr) intact.
Changes:
- Migrate CI workflow steps from
pnpm/action-setupto pinnedpnpm/setupwithinstall: false. - Add the Knip step to the source workflow (
.github/workflows/src/ci.yml) as a non-blocking check. - Add “generated by actionspack” headers to generated workflows/lockfile and update the actionspack lock entries accordingly.
File summaries
| File | Description |
|---|---|
| .github/workflows/src/ci.yml | Switches pnpm installer to pnpm/setup and ensures the Knip step is present in the source workflow. |
| .github/workflows/ci.yml | Regenerated CI workflow reflecting pnpm/setup usage and updated generated-file header formatting. |
| .github/workflows/release.yml | Adds actionspack generated-file header. |
| .github/workflows/release-commit.yml | Adds actionspack generated-file header. |
| .github/workflow.lock.yml | Updates locked dependencies to include pnpm/setup and adds generated-file header. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI breaks when
pnpm/action-setupswitches to pnpm 12 and leaves a broken launcher.Use
pnpm/setupto install the native binary directly, keeping the rest of the CI flow unchanged.