chore(docs): skip type checks to fix docs deploy [ci skip] - #569
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The documented injector imports fail module resolution, so suppressing the errors leaves broken examples.
Pull request overview
Adds temporary TypeScript suppressions to documentation examples to unblock the docs deployment.
Changes:
- Suppresses
devtools.applytyping errors. - Suppresses missing client injector module errors.
File summaries
| File | Summary |
|---|---|
docs/guide/index.md |
Adds @ts-expect-error directives; documented injector imports remain unsupported and require a supported mechanism or restored entrypoints. |
Review details
Suppressed comments (3)
docs/guide/index.md:112
- This directive hides a module-resolution error, not just a missing declaration: the current
@vitejs/devtoolspackage does not export./client/inject, and the core build emits no client entry for it. Copying this documented import therefore fails for consumers; update the docs to the supported injection mechanism or publish/restore the entrypoint instead of suppressing the error.
// @ts-expect-error TODO: Remove when this entry has type declarations.
import '@vitejs/devtools/client/inject'
docs/guide/index.md:118
- This directive hides a module-resolution error, not just a missing declaration: the current
@vitejs/devtoolspackage does not export./client/inject-passive, and the core build emits no client entry for it. Copying this documented import therefore fails for consumers; update the docs to the supported injection mechanism or publish/restore the entrypoint instead of suppressing the error.
// @ts-expect-error TODO: Remove when this entry has type declarations.
import '@vitejs/devtools/client/inject-passive'
docs/guide/index.md:124
- This directive hides a module-resolution error, not just a missing declaration: the current
@vitejs/devtoolspackage does not export./client/inject-hidden, and the core build emits no client entry for it. Copying this documented import therefore fails for consumers; update the docs to the supported injection mechanism or publish/restore the entrypoint instead of suppressing the error.
// @ts-expect-error TODO: Remove when this entry has type declarations.
import '@vitejs/devtools/client/inject-hidden'
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.