Resolve the strictness baseline entries at source - #614
Merged
Conversation
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 13:26
0747e73 to
249d61b
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 13:27
0e57aa7 to
4cc3c2a
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 17:28
249d61b to
7c4d726
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 17:28
4cc3c2a to
522b49c
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 17:43
7c4d726 to
38229c3
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 17:43
522b49c to
c495f0e
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 17:46
38229c3 to
e301a32
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 17:46
c495f0e to
1f4342b
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 17:47
e301a32 to
9db8148
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 17:47
1f4342b to
b4bd9fa
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 17:49
9db8148 to
3711d78
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 17:49
b4bd9fa to
1f6498b
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 17:56
3711d78 to
b70ea90
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 17:56
1f6498b to
2afb67c
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 17:57
b70ea90 to
860d89a
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 17:57
2afb67c to
c3d20b3
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 18:03
860d89a to
b216f12
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 18:03
c3d20b3 to
24e2c50
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 18:04
b216f12 to
7f6f3bd
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 18:04
24e2c50 to
13590f9
Compare
GrahamCampbell
force-pushed
the
docs/behaviour-clarifications
branch
from
August 24, 2026 18:04
7f6f3bd to
ac48f57
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 18:04
13590f9 to
3614321
Compare
GrahamCampbell
force-pushed
the
types/baseline-resolution
branch
from
August 24, 2026 18:06
3614321 to
f656b3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four of the five phpstan baseline entries point at real, if harmless, looseness in the code
rather than at annotation gaps, so this resolves them at source. The lexer now compares the
preg_match result against one explicitly, which throws in exactly the same cases as the previous
falsy check. The byte order mark comparison in Str::utf8 uses strict equality, which agrees with
the loose comparison for every value substr can produce there. The environment adapters split
their read chains so the scalar filter's guarantee is stated once as a checked narrowing instead
of an unverifiable string cast on the mapped result. The regenerated baseline shrinks to the
single remaining lexer entry, where phpstan cannot infer the type of the static pattern cache.