fix(scan): stop one over-long url from dropping the wayback feed#321
Open
TBX3D wants to merge 1 commit into
Open
fix(scan): stop one over-long url from dropping the wayback feed#321TBX3D wants to merge 1 commit into
TBX3D wants to merge 1 commit into
Conversation
the wayback line scanner capped each line at 1mb, so a single archived url with a huge query string made scanner.Err return ErrTooLong and the whole feed was discarded. read lines without a per-line cap, still bounded by the passiveMaxBytes read limit.
github-actions
Bot
added
size/s
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage ? 54.74%
=======================================
Files ? 81
Lines ? 6875
Branches ? 0
=======================================
Hits ? 3764
Misses ? 2842
Partials ? 269 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pr summary2 files changed (+39 -10)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the wayback line scanner capped each line at 1mb, so a single archived
url with a huge query string made scanner.Err return ErrTooLong and the
whole feed was discarded. read lines without a per-line cap, still bounded
by the passiveMaxBytes read limit.