fix(scan): truncate shodan banners on rune boundaries - #326
Merged
Conversation
truncateBanner sliced by byte offset, so a multibyte utf-8 rune landing across the limit was cut mid-sequence and emitted invalid utf-8. shodan banners routinely carry non-ascii bytes, so this corrupted logged and printed output. count runes instead so the cut lands on a boundary.
github-actions
Bot
added
size/s
pr summary2 files changed (+9 -2)
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage ? 54.75%
=======================================
Files ? 81
Lines ? 6874
Branches ? 0
=======================================
Hits ? 3764
Misses ? 2841
Partials ? 269 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vmfunc
approved these changes
Jul 22, 2026
vmfunc
left a comment
vmfunc
left a comment
Owner
There was a problem hiding this comment.
correct fix, byte slicing at maxLen was splitting multibyte runes on hostile banner data. maxLen becomes a rune count instead of a byte count now, which is what you actually want for banner display. good test cases too. in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
truncateBanner sliced by byte offset, so a multibyte utf-8 rune landing
across the limit was cut mid-sequence and emitted invalid utf-8. shodan
banners routinely carry non-ascii bytes, so this corrupted logged and
printed output. count runes instead so the cut lands on a boundary.