test: add Node 20 to node-version matrix (expected red until Vite+ supports it)#84
Merged
Conversation
Cover Node.js 20 in the test-node-version job alongside lts, 22, and 24.
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the CI coverage in .github/workflows/test.yml by adding Node.js 20 to the existing test-node-version matrix, ensuring the action is validated across more supported Node versions.
Changes:
- Added Node.js
20to thetest-node-versionmatrix (["lts", "20", "22", "24"]). - Kept the existing “Verify Node.js version” logic unchanged (it already treats non-
ltsversions generically).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Vite+ requires Node ^22.18.0 || >=24.11.0, so Node 20 is unsupported. A happy-path matrix entry for 20 passed vacuously because the engine gate is only enforced by workload commands like vp install, not by vp env use or vp --version. Replace it with a negative test that runs vp install under Node 20 and asserts it fails with the incompatibility error, reproducing the rolldown CI failure.
fengmk2
changed the title
…+ supports it) Run vp install in the matrix so Node 20 throws at Vite+'s engine gate (requires ^22.18.0 || >=24.11.0). Node 20 is kept red on purpose until Vite+ adds Node 20 support; drop the separate negative-test job.
fengmk2
changed the title
Vite+'s bundled pnpm 11 requires node:sqlite (Node >= 22.5) and crashes on Node 20. Pin the test project to pnpm@10.34.3 so vp install runs the whole node-version matrix, including Node 20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Node 20 to the
test-node-versionmatrix. The job now runsvp install, which enforces Vite+'s Node engine range (^22.18.0 || >=24.11.0), so Node 20 fails at the engine gate (same failure as rolldown CI).This is intentional: Node 20 stays red until Vite+ adds Node 20 support, at which point the same matrix turns green with no test changes.
lts,22, and24install cleanly and pass.