fix(create): run nested app templates from parent dir#1869
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 211971f218
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Formatted the nested-app create changes that were failing |
|
Follow-up pushed: formatted the builtin template files reported by the failing |
|
Pushed a Windows CI fix in |
|
Pushed 6a16a36 to address the Codex inline review: now preserves as the create-vite project argument instead of passing an empty basename, with a regression test for the current-directory target. Local checks: . The targeted Vitest command still cannot start in this checkout because Vitest cannot resolve the local Vite dependency, so CI remains the active validation. |
|
Pushed 6a16a36 to address the Codex inline review: Local checks:
The targeted Vitest command still cannot start in this checkout because Vitest cannot resolve the local Vite dependency, so CI remains the active validation. |
|
Follow-up pushed in 80fd266: the two application-template unit tests now pass independent |
|
Follow-up for the Windows E2E failure: pushed |
Summary
vite:applicationcreation for nested monorepo targets likeapps/temperature-symbolcreate-vitefrom the target parent directory and passes only the leaf project nametargetDirfor later package-name rewriting and monorepo integrationFixes #820.
Verification
git diff --checkpnpm exec tsgo --noEmit -p packages/cli/tsconfig.jsonBlocked
pnpm -F vite-plus test src/create/__tests__/builtin.spec.tsfails at Vitest startup because the local Vite dist file is missing:vite/dist/vite/node/index.js.