fix(setup): reject cli packages without provenance#1871
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ddec74341
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the Codex review findings in
Local validation:
|
|
Pushed a follow-up shell installer fix in Local validation:
|
|
Updated this branch to address the macOS CLI E2E failure where |
| "test": "vitest run" | ||
| }, | ||
| "dependencies": { | ||
| "@napi-rs/cli": "catalog:", |
|
Please reply your proposal to #1826, and then submit a PR. |
Summary
Fixes #1826.
@voidzero-dev/vite-plus-cli-*packages when npm metadata lacksdist.attestations.provenancevp upgrade, the POSIX install script, and the PowerShell install scriptVerification
git diff --checkbash -n packages/cli/install.shRUSTUP_TOOLCHAIN=stable rustfmt --edition 2024 --check crates/vite_setup/src/registry.rs@voidzero-dev/vite-plus-cli-darwin-arm64@0.2.0exposesdist.attestations.provenanceBlocked locally
pwshis not installed in this environment, so I could not run a PowerShell parse checkcargo test -p vite_setup registry::tests::test_dist_info --libfails before compiling because the pinnednightly-2026-06-10toolchain has a missing manifest locally; retrying withRUSTUP_TOOLCHAIN=stablereaches workspace dependency resolution and fails on the nightly-onlyfspydependency fromvite-task