Skip to content

feat(client): support prefix env queries#472

Merged
wan9chi merged 1 commit into
mainfrom
codex/getenvs-prefix-query
Jun 18, 2026
Merged

feat(client): support prefix env queries#472
wan9chi merged 1 commit into
mainfrom
codex/getenvs-prefix-query

Conversation

@wan9chi

@wan9chi wan9chi commented Jun 18, 2026

Copy link
Copy Markdown
Member

Motivation

Allow runner-aware tools to request environment variables by literal prefix, including prefixes that contain glob metacharacters such as *, without treating those characters as wildcards.

wan9chi commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

wan9chi added a commit that referenced this pull request Jun 18, 2026
## Motivation

Prepare the env-query tracking path for the stacked `getEnvs({ prefix:
"..." })` feature in #472. That feature needs the runner to distinguish
different bulk env query kinds instead of treating every `getEnvs`
request as a raw glob string.

This PR keeps behavior unchanged by introducing an explicit env query
type with only the existing glob variant, then threading that type
through IPC, the recorder, cache fingerprinting, and reporting. The
follow-up PR can add a prefix variant as a small behavior change on top
of this plumbing.

Co-authored-by: GPT-5 Codex <codex@openai.com>
Base automatically changed from codex/refactor-env-query to main June 18, 2026 14:58
@wan9chi wan9chi force-pushed the codex/getenvs-prefix-query branch 2 times, most recently from 3c22082 to ed43482 Compare June 18, 2026 15:11
Co-authored-by: GPT-5 Codex <codex@openai.com>
@wan9chi wan9chi force-pushed the codex/getenvs-prefix-query branch from ed43482 to e80088d Compare June 18, 2026 15:18
@wan9chi wan9chi marked this pull request as ready for review June 18, 2026 15:24
@wan9chi wan9chi merged commit 619e1d6 into main Jun 18, 2026
19 checks passed
@wan9chi wan9chi deleted the codex/getenvs-prefix-query branch June 18, 2026 15:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e80088d9be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_task/src/session/execute/fingerprint.rs
wan9chi added a commit that referenced this pull request Jun 18, 2026
## Motivation

Keep the changelog entry for `@voidzero-dev/vite-task-client` concise after publishing 0.2.0: retain the `#472` PR link in the existing client entry, but remove the extra feature description that was added for the prefix query change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant