Skip to content

Fix python formatting after typechecker change - #9828

Merged
robert3005 merged 2 commits into
developfrom
rk/formatting
Sep 10, 2026
Merged

Fix python formatting after typechecker change#9828
robert3005 merged 2 commits into
developfrom
rk/formatting

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This was a semantic conflict

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Sep 10, 2026
@robert3005
robert3005 enabled auto-merge (squash) September 10, 2026 14:36
Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed-hq

codspeed-hq Bot commented Sep 10, 2026

Copy link
Copy Markdown

Merging this PR will regress 4 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 4 regressed benchmarks
✅ 2191 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 13.3 µs 20.3 µs -34.39%
WallTime words_gather_scalar_avx512[1024] 99 ns 124 ns -20.16%
WallTime mul_u32_nonnull_avx512 5.6 µs 6.3 µs -11.25%
WallTime mul_i32_nonnull_avx512 7.1 µs 7.9 µs -10.05%
WallTime words_gather_dispatch_avx2[1024] 46 ns 17 ns ×2.7
WallTime arrow_checked_add_u32_avx2[16384] 21.4 µs 17.6 µs +21.31%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/formatting (1839f45) with develop (a13c246)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005
robert3005 disabled auto-merge September 10, 2026 14:54
@robert3005
robert3005 merged commit 9fdaa38 into develop Sep 10, 2026
84 of 85 checks passed
@robert3005
robert3005 deleted the rk/formatting branch September 10, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants