Change release process to make releases immutable - #9845
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will regress 2 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | filtered_owned_i64_avx512[OneNullInEight] |
22.3 µs | 26.3 µs | -15.22% |
| ❌ | WallTime | words_gather_scalar_avx2[65536] |
8.3 µs | 9.4 µs | -11.94% |
| ⚡ | WallTime | mul_u64_nonnull_neon |
21.3 µs | 15.4 µs | +37.79% |
| ⚡ | WallTime | arrow_checked_add_u32_avx2[16384] |
21.4 µs | 17.6 µs | +21.44% |
| ⚡ | WallTime | arrow_checked_add_u32_avx512[16384] |
21.2 µs | 17.6 µs | +20.76% |
| ⚡ | WallTime | multiply_shapes_neon[(16384, PerRowPerRow)] |
20.3 µs | 17.3 µs | +17.29% |
| ⚡ | WallTime | mul_i64_nonnull_neon |
20.2 µs | 17.3 µs | +16.83% |
| ⚡ | WallTime | filtered_owned_i64_avx2[OneNullInEight] |
25.8 µs | 22.2 µs | +16.36% |
| ⚡ | Simulation | compact_sliced[(1024, 90)] |
1.5 µs | 1.4 µs | +12.03% |
| ⚡ | Simulation | compact_sliced[(2048, 90)] |
1.6 µs | 1.4 µs | +11.53% |
| ⚡ | WallTime | dict_canonicalize_gt_u8_avx2[16000000] |
8 ms | 7.2 ms | +11.5% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/releases (8fab907) with develop (d1fe2dc)2
Footnotes
-
218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(ed4733f) during the generation of this report, so d1fe2dc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Document that binaries have to be built manually when making a release to allow
us to make releases immutable. Instead of appending binaries to an existing
release on publish we append them to draft and only publish once they're
populated