Skip to content

fix: reject overflowing transfer amounts - #212

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/reject-overflowing-transfer-amounts
Open

vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/reject-overflowing-transfer-amounts

Conversation

@vycdev2

@vycdev2 vycdev2 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • reject transfer amounts when adding the 5% fee would overflow decimal
  • calculate transfer fees before opening a database transaction
  • cover normal and overflowing transfer totals with regression tests

Verification

  • dotnet test --no-restore --filter FullyQualifiedName~StocksServiceTests — passed: 7 tests
  • dotnet build --no-restore — passed: 0 warnings, 0 errors
  • dotnet test --no-build --no-restore — passed: 621 tests, 3 skipped
  • git diff --check — passed

Risk

  • Low. The change only rejects values that could not previously produce a representable transfer total.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant