Skip to content

Accept string API keys in all connection helpers - #2145

Open
mimimind wants to merge 2 commits into
weaviate:mainfrom
mimimind:string-auth-credentials
Open

Accept string API keys in all connection helpers#2145
mimimind wants to merge 2 commits into
weaviate:mainfrom
mimimind:string-auth-credentials

Conversation

@mimimind

Copy link
Copy Markdown

Summary

  • align the remaining sync and async connection helper annotations with their documented runtime support for string API keys
  • cover sync custom, async cloud, and async custom helpers without network access

Fixes #996.

Validation

  • 11 related connection and authentication tests passed
  • Ruff passed
  • Flake8 passed
  • Pyright passed

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot

Copy link
Copy Markdown

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Forum?

@mimimind

Copy link
Copy Markdown
Author

I have read and agree to the Weaviate Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Union[str, AuthApiKey, AuthOIDCxxx, ...] as auth_credentials inputs in connection helper functions

2 participants