Skip to content

Support empty dynamic filters - #2146

Open
mimimind wants to merge 5 commits into
weaviate:mainfrom
mimimind:dynamic-filters
Open

Support empty dynamic filters#2146
mimimind wants to merge 5 commits into
weaviate:mainfrom
mimimind:dynamic-filters

Conversation

@mimimind

Copy link
Copy Markdown

Summary

  • let Filter.all_of() ignore None entries and return a serializable no-op filter when no entries remain
  • omit no-op filters from gRPC and REST requests, including when combined or inverted
  • cover empty, all-None, mixed, and composed dynamic filters

Fixes #1092.

Validation

  • test/collection/test_filter.py: 38 passed
  • test/collection: 326 passed, 1 skipped
  • full unit suite: 419 passed, 1 skipped; 2 unrelated Windows-only timeout-output assertion failures
  • Ruff and Flake8 passed on weaviate and test
  • Pyright on changed source: 0 errors

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot

Copy link
Copy Markdown

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Forum?

@mimimind

Copy link
Copy Markdown
Author

I have read and agree to the Weaviate Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dynamic filters

2 participants