NFC-169 Fix PHP auth cert chain, format, SSRF, cookie and OCSP checks#63
Open
SanderKondratjevNortal wants to merge 2 commits into
Open
NFC-169 Fix PHP auth cert chain, format, SSRF, cookie and OCSP checks#63SanderKondratjevNortal wants to merge 2 commits into
SanderKondratjevNortal wants to merge 2 commits into
Conversation
Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com>
Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com>
mrts
requested changes
Jun 22, 2026
| { | ||
| return $format !== null && | ||
| str_starts_with($format, self::V1_SUPPORTED_TOKEN_FORMAT_PREFIX); | ||
| return $format === self::V1_SUPPORTED_TOKEN_FORMAT_PREFIX || |
Member
There was a problem hiding this comment.
As in Java and .NET, minor versions must be backward-compatible within the major version, this will reject future compatible web-eid:1.x tokens. Use the same regex-based approach as in in Java and .NET.
mrts
reviewed
Jun 22, 2026
| * @throws CertificateDecodingException | ||
| * @throws AuthTokenException | ||
| */ | ||
| public function testSigningCertificateChainValidationFails(): void |
Member
There was a problem hiding this comment.
There are 3 PHPCS errors:
$ ./vendor/bin/phpcs
............................................................ 60 / 123 (49%)
E............................E.E............................ 120 / 123 (98%)
... 123 / 123 (100%)
FILE: web-eid/web-eid-authtoken-validation-php/src/validator/certvalidators/SubjectCertificateNotRevokedValidator.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
59 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
60 | ERROR | [x] The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
FILE: web-eid/web-eid-authtoken-validation-php/tests/certificate/CertificateValidatorTest.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
38 | ERROR | [x] Opening brace must not be followed by a blank line
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------
FILE: web-eid/web-eid-authtoken-validation-php/tests/validator/versionvalidators/AuthTokenVersion11ValidatorTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
261 | ERROR | [x] Expected 1 space after class keyword; 0 found
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
Time: 415ms; Memory: 10MB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sander Kondratjev sander.kondratjev@nortal.com