fix(widgets): bump sdk-component-adapter to 1.113.3 and components to 1.277.1 - #730
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7d6b307e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@webex/components": "1.277.1", | ||
| "@webex/sdk-component-adapter": "1.113.3", |
There was a problem hiding this comment.
Keep the module spec aligned with the dependency pins
These dependency pins are updated, but packages/@webex/widgets/ai-docs/widgets-spec.md:138-141 still identifies @webex/sdk-component-adapter 1.112.12 and @webex/components 1.275.2 as the required versions. This leaves the module's documented integration baseline stale; update the spec with the new pins in this change.
AGENTS.md reference: AGENTS.md:L68-L68
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
rarajes2
left a comment
There was a problem hiding this comment.
Please check if codex comment is valid
Fixed the codex comment |
Thank you for your contribution! |
COMPLETES https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-824300
This pull request addresses
Meetings Widget device switching and meeting controls (⋯ menu, roster, mute, join, etc.) broke after
@webex/sdk-component-adapter@1.113.0shipped with sdk-component-adapter#346. The adapter expected controlaction({ meetingID })context objects, but@webex/components@1.277.1still callsaction(meetingID)(string) andaction(meetingID, deviceId)for device switches — causingCould not find meeting with ID "undefined"and failed mic/speaker/camera selection.Fix landed in adapter: sdk-component-adapter#350, published as
@webex/sdk-component-adapter@1.113.3on npm.Customer-reported stack:
@webex/widgets^1.28.2,@webex/components1.277.1,@webex/sdk-component-adapter1.113.0, Chrome on macOS.Demo recordings:
by making the following changes
Dependency bump in
packages/@webex/widgets/package.json(andyarn.lock):@webex/sdk-component-adapter@webex/componentsNo widget source code changes — consumers of
@webex/widgetsget the adapter fix via the updated pinned dependencies.Change Type
The following scenarios were tested
yarn test:meetings-widget— 30/30 unit tests pass (WebexMeetings.test.jsx)yarn workspace @webex/widgets startwith npm packages (no portal link)meetingID undefinederrorsThe GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.