Skip to content

fix: authenticate GitHub API requests and remove outdated release TODOs - #252

Merged
avivkeller merged 2 commits into
webpack:mainfrom
moshams272:docs/remove-webpack5-release-todos
Aug 21, 2026
Merged

fix: authenticate GitHub API requests and remove outdated release TODOs#252
avivkeller merged 2 commits into
webpack:mainfrom
moshams272:docs/remove-webpack5-release-todos

Conversation

@moshams272

@moshams272 moshams272 commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

This PR removes outdated (TODO: ...) notes in the Webpack 5 release blog post, and spreads the githubHeaders object to attach GitHub authentication headers, preventing API rate limiting and CI script failures.

Verification on docs:

I double-checked the Webpack 5 source code:

  • optimizationBailout is in ModuleGraph (not ChunkGraph).
  • getChildIdsByOrders and getChildIdsByOrdersMap are remain in the Chunk.

Summary by CodeRabbit

  • Documentation

    • Removed outdated TODO notes from descriptions of several Webpack 5 API and optimization changes.
  • Bug Fixes

    • Improved error reporting when repository discovery requests fail.
    • Preserved existing request headers while adding GitHub authentication and API headers.

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview Aug 20, 2026 3:01pm

Request Review

@github-actions github-actions Bot added documentation Improvements or additions to documentation blog labels Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Removed obsolete TODO notes from the Webpack 5 release post. Added error handling for unsuccessful GitHub API responses. Updated fetchWithAuth to merge GitHub headers with existing request headers.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes both main changes: GitHub API authentication fixes and removal of outdated release TODOs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@moshams272

Copy link
Copy Markdown
Member Author

Build failure on docs commit!!!

@moshams272

Copy link
Copy Markdown
Member Author

Oh, we actually forget to spread the object ;)

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0bb4765f-e0a1-4490-8edd-6a80d52e3cf0

📥 Commits

Reviewing files that changed from the base of the PR and between 827cbb3 and 3acbaff.

📒 Files selected for processing (2)
  • scripts/markdown/readmes.mjs
  • scripts/utils/fetch.mjs
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • webpack/webpack (auto-detected)

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Comment thread scripts/utils/fetch.mjs
@moshams272 moshams272 changed the title docs: remove TODO notes from Webpack 5 release post fix: authenticate GitHub API requests and remove outdated release TODOs Aug 20, 2026
@avivkeller
avivkeller merged commit cd2b3e2 into webpack:main Aug 21, 2026
14 checks passed
@moshams272
moshams272 deleted the docs/remove-webpack5-release-todos branch August 21, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blog documentation Improvements or additions to documentation tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants