Fix Storybook CI step invoking wrong npm script - #997
Merged
Conversation
'pnpm storybook build --output-dir ...' ran the 'storybook' npm script (storybook dev -p 6006) and appended args, causing 'unknown option'. Use 'pnpm storybook:build' to invoke the correct build script. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LgBsw219iQB1xJVRdwbkxN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
astro.ymlRoot cause
The step ran
pnpm storybook build --output-dir public/styleguide. Becausestorybookis defined inpackage.jsonasstorybook dev -p 6006, pnpm expanded it tostorybook dev -p 6006 build --output-dir public/styleguide— passingbuildas an unknown option to the dev server command.Fix
Changed to
pnpm storybook:build, which maps directly tostorybook build --output-dir public/styleguide.Generated by Claude Code