WPB-26782: keep recurring meetings alive past original lot#5309
Open
blackheaven wants to merge 3 commits into
Open
WPB-26782: keep recurring meetings alive past original lot#5309blackheaven wants to merge 3 commits into
blackheaven wants to merge 3 commits into
Conversation
blackheaven
force-pushed
the
gdifolco/WPB-26782-meeting-fix-end
branch
from
027131c to
242faad
Compare
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates meeting expiry/cleanup semantics so recurring meetings remain accessible after their original time slot has passed, aligning API visibility and background cleanup behavior with the recurrence window (recurrence.until), including “never expire” behavior for open-ended recurrences.
Changes:
- Introduces
effectiveEndTime/isAliveto treat bounded recurrences as alive untilmax(endTime, recurrence.until)and open-ended recurrences as non-expiring. - Updates Postgres queries and in-memory test interpreter filtering/cleanup to use the effective end time instead of
endTime. - Adds unit + integration coverage and documents the behavior change in the changelog.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/wire-subsystems/test/unit/Wire/MockInterpreters/MeetingsStore.hs | Updates mock store list/cleanup filtering to use effectiveEndTime. |
| libs/wire-subsystems/test/unit/Wire/MeetingsSubsystem/InterpreterSpec.hs | Adds unit tests covering recurrence-vs-expiry behavior across core operations and cleanup. |
| libs/wire-subsystems/src/Wire/MeetingsSubsystem/Interpreter.hs | Centralizes expiry checks via isAlive (based on Store.effectiveEndTime) for multiple operations. |
| libs/wire-subsystems/src/Wire/MeetingsStore/Postgres.hs | Updates list and cleanup SQL to apply “effective end time” semantics for recurring meetings. |
| libs/wire-subsystems/src/Wire/MeetingsStore.hs | Adds effectiveEndTime helper defining the new expiry/cleanup rules. |
| integration/test/Test/Meetings.hs | Adds integration test ensuring recurring meetings remain accessible/listed past validity period. |
| changelog.d/3-bug-fixes/WPB-26782 | Documents the behavioral fix for recurring meeting expiry and cleanup. |
battermann
requested changes
Jul 3, 2026
battermann
left a comment
battermann
left a comment
Contributor
There was a problem hiding this comment.
my findings are only nit-picks
but please consider the copilot comment on the index, it might be relevant
| resp <- getMeetingsList owner | ||
| assertSuccess resp | ||
| meetings <- resp.json & asList | ||
| length (meetings :: [Value]) `shouldMatchInt` 1 |
Contributor
There was a problem hiding this comment.
type annotation not needed here, I think
Comment on lines
+911
to
+914
| let now = UTCTime (fromGregorian 2026 1 1) 0 | ||
| gen = mkStdGen 42 | ||
| uid = Id $ read "00000000-0000-0000-0000-000000000001" | ||
| zUser = toLocalUnsafe (Domain "wire.com") uid |
Contributor
There was a problem hiding this comment.
I like to make this a property test and have this generated as input. But no need to change, this is just a comment.
- getOldMeetingsImpl: replace eff_end subselect with a sargable predicate so the non-recurring branch can use idx_meetings_end_time, avoiding a full-table sequential scan + sort in the cleanup worker. - integration (Meetings): fix an inaccurate "endTime = now: past" comment (it only becomes past after the threadDelay) and drop a redundant type annotation. - add a property test asserting meeting aliveness follows effectiveEndTime across getMeeting/listMeetings/cleanupOldMeetings.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26782
Checklist
changelog.d