Add wolfBoot HAL port for RealTek RTL8735B (AmebaPro2)#797
Draft
dgarske wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds initial wolfBoot HAL enablement for the RealTek RTL8735B (AmebaPro2) platform, including build integration and packaging support for producing a flashable image using the vendor SDK tooling.
Changes:
- Introduces a new RTL8735B HAL implementation and linker script for SRAM-staged boot.
- Adds an SDK shim header to avoid pulling FreeRTOS/CMSIS-OS into the wolfBoot build.
- Adds build system wiring (arch.mk), example config, and a packaging script to generate
flash_ntz.bin.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/amebapro2_package.sh | Adds packaging flow to convert wolfboot.elf into a vendor-style flash image. |
| hal/rtl8735b/sdk-shim/cmsis_os.h | Provides CMSIS-OS opaque typedefs to compile SDK headers without FreeRTOS. |
| hal/rtl8735b/README | Documents the RTL8735B HAL design, backends, and SDK integration approach. |
| hal/rtl8735b.ld | Defines SRAM layout, RAM start-table placement, and partition symbols. |
| hal/rtl8735b.c | Implements RTL8735B HAL + RAM start-table/trampoline + SDK-backed ext flash/cache hooks. |
| config/examples/rtl8735b.config | Provides an example configuration for RTL8735B builds and partition layout. |
| arch.mk | Adds TARGET=rtl8735b build integration and SDK include/define wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+39
to
+41
| rm -rf "$OUTDIR" | ||
| mkdir -p "$OUTDIR" | ||
| cd "$OUTDIR" |
Comment on lines
+51
to
+55
| .edidx : | ||
| { | ||
| . = ALIGN(4); | ||
| *(.ARM.exidx*) | ||
| } > SRAM |
Comment on lines
+192
to
+204
| for (i = 0; i < sz; i++) { | ||
| #ifdef HAL_BACKEND_SDK | ||
| /* rt_printf is the 8735B console macro routing through the ROM | ||
| * stdio_printf_stubs to the LOGUART. */ | ||
| if (buf[i] == '\n') { | ||
| rt_printf("%c", (int)'\r'); | ||
| } | ||
| rt_printf("%c", (int)buf[i]); | ||
| #else | ||
| (void)buf; | ||
| (void)i; | ||
| #endif | ||
| } |
Comment on lines
+298
to
+300
| (void)flash_stream_read(&hal_flash_obj, (uint32_t)address, (uint32_t)len, | ||
| data); | ||
| return len; |
| HAL_SDK_INC=$(patsubst -iquote,-I,$(HAL_SDK_IQUOTE)) | ||
| HAL_SDK_DEFS=-DCONFIG_PLATFORM_8735B -DCONFIG_RTL8735B_PLATFORM=1 \ | ||
| -DCONFIG_BUILD_RAM=1 | ||
| hal/rtl8735b.o: CFLAGS += $(HAL_SDK_IQUOTE) $(HAL_SDK_INC) $(HAL_SDK_DEFS) -mcmse -Wno-error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.