Align wolfSSL_set1_groups_list() arg handling with OpenSSL#10686
Open
Frauschi wants to merge 1 commit into
Open
Align wolfSSL_set1_groups_list() arg handling with OpenSSL#10686Frauschi wants to merge 1 commit into
Frauschi wants to merge 1 commit into
Conversation
Frauschi
force-pushed
the
openssl_group_align
branch
from
8be7a32 to
ada225a
Compare
Align the argument parsing and handling of input group names to align it with OpenSSL behavior: * Do a case-insensitive comparison of the input names with our names * Add aliases for "MLKEMxxx" groups without underscores in addition to our names with underscores (keep our for backward compatibility) * Extend unit tests for both
Frauschi
force-pushed
the
openssl_group_align
branch
from
ada225a to
fe3d23e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the argument parsing and handling of input group names to align it with OpenSSL behavior:
MLKEMxxxgroups without underscores in addition to our names with underscores (keep ours for backward compatibility).Identified while fixing PQC key exchange in curl when using wolfssl.