XTS Streaming .S and _c.c implementations, streaming callers & SVR brackets for aarch64 - #11423
Open
kaleb-himes wants to merge 23 commits into
Open
kaleb-himes wants to merge 23 commits into
kaleb-himes wants to merge 23 commits into
Conversation
Merged
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview-nofallback-L
branch
from
September 10, 2026 12:25
e276d22 to
970b6bf
Compare
Contributor
Author
|
retest this please. |
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview-nofallback-L
branch
from
September 10, 2026 23:40
d17f573 to
44de270
Compare
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview-nofallback-L
branch
from
September 11, 2026 16:42
e492336 to
a27db55
Compare
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview-nofallback-L
branch
from
September 11, 2026 18:54
a27db55 to
3672e6b
Compare
4 tasks
kaleb-himes
commented
Sep 13, 2026
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview-nofallback-L
branch
from
September 25, 2026 21:10
deb9eb7 to
0004fcc
Compare
kaleb-himes
force-pushed
the
PQ-FS-2026-Part3-SecurityReview-nofallback-L
branch
from
September 28, 2026 22:55
0004fcc to
9ecb80d
Compare
SparkiDev
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/wolfSSL/scripts/pull/670
taught the aarch64 crypto-extension generator to emit the AES-XTS streaming routines, but that PR regenerated only the MASM (armv8-aes-asm.asm). This PR regenerates the .S and _c.c twins from that same, already-merged generator so all three outputs agree. armv8-aes-asm.asm is untouched here and there is no partner scripts/ PR because 670 already did all the work.
In addition to the regenerated files:
aes.c / aes.h: The streaming callers dispatch into the crypto-extension asm (47 + 8 lines)
SAVE/RESTORE_VECTOR_REGISTERS claims around the aarch64 NEON and crypto lanes: aes.c, sha256.c, sha512.c, wc_mlkem.c, wc_mlkem_poly.c
SHA-3 aarch64 crypto lane claims the vector registers (sha3.c)
linuxkm arm64 vector-register glue on kernel_neon_begin, enabling ARM SIMD in the kernel module (linuxkm/arm64_vector_register_glue.c, plus Kbuild/PIE-table/configure plumbing)
NOTE: There is a known NEON gap for any aarch64 device that does NOT have the crypto extensions and I am happy to add that as a followup PR but this PR was already just over 5k lines of additions and adding that would have swelled it to 16-17k lines + a scripts/ generator update to go with it and that felt like too much to take on in a single PR.
Fixes zd#
Testing
Checklist