Compat layer: address several X509_V_FLAG values set to 0 - #11470
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
padelsbach
force-pushed
the
ossl-compat-issue-03
branch
2 times, most recently
from
September 28, 2026 21:55
46f6a77 to
9a14f21
Compare
wolfSSL-Fenrir-bot
requested changes
Sep 28, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11470
Scan targets checked: wolfssl-src, wolfssl-bugs
Coverage: 1 of 4 in-scope changed file(s) opened by the reviewer; not opened: wolfssl/openssl/ssl.h, wolfssl/openssl/x509.h, wolfssl/ssl.h
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
padelsbach
force-pushed
the
ossl-compat-issue-03
branch
from
September 28, 2026 22:55
9a14f21 to
5974ace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several
X509_V_FLAGdefines were found to be zero, and thusX509_VERIFY_PARAM_set_flagswould silently accept them silently without making the corresponding change. This PR makes the flags match OpenSSL and returns failure when a caller tries to set unsupported modes.Testing
Added unit tests
Checklist