pdfium5 upgrade and workaround for pdfs with broken Page structrues - #1033
Open
jimporter-droid wants to merge 4 commits into
Open
pdfium5 upgrade and workaround for pdfs with broken Page structrues#1033jimporter-droid wants to merge 4 commits into
jimporter-droid wants to merge 4 commits into
Conversation
…e if it fixes the reproducable failure.
…gradle repository that does not seem to be needed anymore since it is on maven central and not jitpack now.
Owner
|
Thank you for your commit, |
Author
|
@wonday resync complete, ready for review/feedback. Thanks for supporting this library! |
Owner
|
@jimporter-droid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an occasional crash report in our apps around rn-pdf. While I couldn't find a definitive cause I did see a similar issue that had no resolution but someone shared an example pdf. I made a repro app and could confirm that the sample pdf did not work but a separate correct sample pdf did work. To solve for the crash around the broken pdf I found issues of a similar nature that had been resolved in pdfviewer. So I performed the upgrade and solved an issue around a race condition when handling the pdfs with a broken page structure. Everything seems very stable and I can reliably load either type of pdf on cold startup or warm startup or HMR switch back and forth of the asset.
Let me know if anything needs additional work before merging. We have this as a patch in our upcoming native release so I'll have some more data on whether or not the crash in production is solved by this upgrade.