feat: expose authentication method on action contexts - #139
Merged
Conversation
Greptile SummaryThe PR exposes the signed action payload’s authentication method through
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "fix: make authentication_method optional..." | Re-trigger Greptile |
Contributor
Author
|
session restore failed HTTP 422: ENOSPC: no space left on device, write |
A missing or null authentication_method made construct_action return a decode error, failing a customer's entire Actions endpoint instead of returning an Allow/Deny verdict. AuthenticateResponse already models the same field as an Option, and the Go and Node SDKs degrade to a zero value rather than erroring. Restores coverage for the field-free payload, which the updated tests no longer exercised, and pins the Unknown forward-compat fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to workos/workos#68754. Expose
authentication_methodon the typedActionContextreturned by the Actions helper for authentication and user registration payloads. This reuses the existingAuthenticateResponseAuthenticationMethodenum.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
The Actions API documentation is covered by the API change; this PR only makes the existing payload field available through the Rust helper.
Test plan
cargo fmt --checkcargo test helpers::actions::testsRequested by zac.burrage@workos.com via TARS