fix: revalidate blog 404s instead of pinning them for a year - #385
Draft
josephfusco wants to merge 1 commit into
Draft
fix: revalidate blog 404s instead of pinning them for a year#385josephfusco wants to merge 1 commit into
josephfusco wants to merge 1 commit into
Conversation
An empty query response is indistinguishable from a genuinely missing post, so returning notFound without revalidate lets Next cache a transient upstream failure at s-maxage=31536000.
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getStaticPropscannot distinguish a deleted post from a failed query, since both return empty. Withoutrevalidate, Next pinss-maxage=31536000on the resulting 404, so a momentary upstream failure takes a live post offline for a year.The #383 preview deploy hit exactly this: four of six posts still 404 at the edge despite rendering correctly at the source, because they were requested during the window before the persisted query registered.
Adding
revalidateto the 404 branch does not prevent a bad 404, it caps it at five minutes.AI usage
Model(s): claude-opus-5
Used for: Root cause investigation, drafting, and implementation