Recompute in_network on cached For You posts - #135
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Conversation
This was referenced Sep 7, 2026
Closed
Closed
FollowedUserIdsQueryHydrator still runs on cache hits. Skipping InNetworkCandidateHydrator left the cached in_network bit in place after follow/unfollow, so VF kept using TimelineHome for a just- unfollowed author.
Pitchfork-and-Torch
force-pushed
the
cursor/cache-hit-stale-in-network-eadf
branch
from
September 8, 2026 23:12
8424514 to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
Author
|
Reopened. This was a serving-path hunt PR parked by mistake during the 2026-09-08 intern-stack cleanup. Not a reject of the class. Leaving it for xAI review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
InNetworkCandidateHydrator.enableis!has_cached_posts.FollowedUserIdsQueryHydratorstill runs on a cache hit. The follow list is current. The hydrator is a set lookup onauthor_id. Skipping it keeps thein_networkbit written up to 180s earlier.VFCandidateHydratorbuckets onin_network.unwrap_or(false). StaleSome(true)after unfollow is fetched atTimelineHome. Recs-only Drop does not run (DO_NOT_AMPLIFY,SPAM_HIGH_RECALL,NSFW_HIGH_RECALL, civic-integrity, and the rest of the Recs table).OONRetweetReplyFilterandOONNsfwSimclustersFilteralso needSome(false).CachedPostsQueryHydratorsetshas_cached_postswhen Redis returns at least 500 posts. TTL is 180s.This is the leftover called out on #131. Not #128 (TES-before-InNetwork order). Not #117 (QuoteHydrator graph miss).
Fix
Always enable. Recompute from the live follow list.
updateoverwrites the cached bit.Tests
enableis true on cache hit and misstrue, unfollowed →false, self →trueStandalone decision-table harness (same enable + VF bucket predicate): 6 assertions passed.
cargo testcannot run here. Public dump has no Home Mixer manifest.