Stop Thunder from burying undeleted in-network posts - #186
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Stop Thunder from burying undeleted in-network posts#186Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This was referenced Sep 8, 2026
Closed
TweetUndeleteEvent was dropped on the feeder, and insert_posts refused tombstoned ids, so a restored tweet stayed off For You until retention trim. Handle undelete like create and clear the tombstone on re-insert.
Pitchfork-and-Torch
force-pushed
the
cursor/magellan-wave2-undelete-4eaf
branch
from
September 8, 2026 23:07
9ef9bdf to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Thunder delete has a handler. Thunder undelete does not. A restored followee tweet stays off For You until the tombstone ages out.
Five-line proof
TweetDeleteEventremoves the CompactPost and insertspost_idintodeleted_posts.TweetUndeleteEventwith the same tweet/user payload as create._ => {}, so noInNetworkEventwas emitted.insert_postsrefused any later create for a tombstoned id (if deleted_posts.contains_key { continue }).GetInNetworkPoststherefore omitted the restored tweet for up to the retention window.Twin: delete is handled; undelete is not. This is not #138 (QuotedTweetDelete kills the quote) and not #150 (RT of a tombstoned original).
Fix
TweetUndeleteEventthrough the same LightPost builder as create (nullcast still skipped) and emitsTweetCreateEvent.Tests
undelete_clears_tombstone_and_restores_post(fails on unmodified main)cargo: cannot run. Public dump has no Thunder manifest.
Rejection table (this wave)