Stop SubscriptionHydrator from skipping exclusive ids on quotes - #190
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Conversation
Phoenix TES exclusive lookup keyed only the quote wrapper tweet_id. Super Follow lives on the quoted original, so IneligibleSubscriptionFilter kept the card as public. Fetch the quoted id and use it when the wrapper is not exclusive. Retweet originals stay xai-org#155.
Pitchfork-and-Torch
force-pushed
the
cursor/magellan-overnight-c-quoteex-90e9
branch
from
September 8, 2026 23:07
843f3a9 to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Phoenix SubscriptionHydrator asks TES for exclusive authors by wrapper tweet_id. Super Follow lives on the quoted original. A quote wrapper is not exclusive, so subscription_author_id stays None and IneligibleSubscriptionFilter keeps the card.
#155 keys retweet originals via get_original_tweet_id(). That helper is retweeted_tweet_id.unwrap_or(tweet_id). Quotes keep the wrapper id. This is the leftover quoted exclusive TES key.
This is not #155 (retweet original). This is not #118 (quoted id hydration). This is not #129 (subscription-list miss). This is not #141 (TES exclusive fail-closed).
This is not #184 (ads served history). This is not #157 (Explore topic hydration). This is not #170 (rank-all NSFW index). This is not #146 (soft VF Avoid/Tombstone/Interstitial).
Proof
Fix
Fetch TES exclusive authors for tweet_id and quoted_tweet_id. Use the wrapper author when the quote itself is exclusive. Use the quoted author when the wrapper is not exclusive and the quoted original is. Retweet originals stay #155.
Tests
Fork PR: none
Survey: #96-#188. Unclaimed. Not steward ads/Explore/soft-demotion/NaN.