Development#4
Open
xsrust wants to merge 2429 commits into
Open
Conversation
…load_page Updated the font_face value in DEFAULT_SETTINGS from 'Arial, Helvetic…
…h_outputs Added JS constants to be used in the Research Outputs feature
Updated fontawesome to V6
fix typo, probably introduced by v1 code
Issue 3316
added .gitkeep file to assets/builds to address issues in production …
Add error message and update saving message for plan writing
Update Gemfile.lock and yarn.lock
Revert "Update Gemfile.lock and yarn.lock"
Update tp gems.
Development
This commit consists of the file changes required for the upgrade from Bootstrap 3 to 5. A more detailed version is in CHANGELOG.md (and in wiki: https://github.com/DMPRoadmap/roadmap/wiki/Release-notes-for-Bootstrap-5-upgrade)
According to https://github.com/titusfortner/webdrivers: "If you can update to the latest version of Selenium (4.11+), please do so and stop requiring this gem."
Without this modification, the selenium tests often trigger a 429 / Too Many Requests error. (Perhaps this should be applied to "/users/password" as well?)
Prior to this commit, the following deprecation warning was appearing in the terminal: NOTE: Faker::Internet.safe_email is deprecated; use email instead. It will be removed on or after 2023-10. More here: faker-ruby/faker#2733
Prior to this commit, the GitHub Actions associated with these files were failing with the message, "Invalid workflow file The workflow is not valid. .github/workflows/mysql.yml (Line: X, Col: Y): 'node-version' is already defined"
NOTE: Additional Rubocop offences currently exist in the codebase. These fixes only address the PR changes that correspond with this commit.
Changes in this PR: 1) modal-search-result-selector class changed from 'hidden' to 'd-none' 2) changes to the related rspec tests for the above
Fix rendering of `confirm_merge` partial
Merge `next-release/v5.0.2` into `main`
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.17.2 to 1.18.9. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.17.2...v1.18.9) --- updated-dependencies: - dependency-name: nokogiri dependency-version: 1.18.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…1.18.9 Bump nokogiri from 1.17.2 to 1.18.9
Bumps [activerecord](https://github.com/rails/rails) from 7.1.5.1 to 7.1.5.2. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.0.2.1/activerecord/CHANGELOG.md) - [Commits](rails/rails@v7.1.5.1...v7.1.5.2) --- updated-dependencies: - dependency-name: activerecord dependency-version: 7.1.5.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ord-7.1.5.2 Bump activerecord from 7.1.5.1 to 7.1.5.2
Bumps [rack-session](https://github.com/rack/rack-session) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/rack/rack-session/releases) - [Changelog](https://github.com/rack/rack-session/blob/v2.1.1/releases.md) - [Commits](rack/rack-session@v2.1.0...v2.1.1) --- updated-dependencies: - dependency-name: rack-session dependency-version: 2.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ion-2.1.1 Bump rack-session from 2.1.0 to 2.1.1
Bumps [net-imap](https://github.com/ruby/net-imap) from 0.4.19 to 0.4.20. - [Release notes](https://github.com/ruby/net-imap/releases) - [Commits](ruby/net-imap@v0.4.19...v0.4.20) --- updated-dependencies: - dependency-name: net-imap dependency-version: 0.4.20 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…0.4.20 Bump net-imap from 0.4.19 to 0.4.20
Bumps [rexml](https://github.com/ruby/rexml) from 3.4.1 to 3.4.2. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.4.1...v3.4.2) --- updated-dependencies: - dependency-name: rexml dependency-version: 3.4.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bump rexml from 3.4.1 to 3.4.2
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.3 to 0.2.4. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…0.2.4 Bump tmp from 0.2.3 to 0.2.4
- Commit 02a7cfc bumped the Rubocop version, which resulted in more offences. - These offences should be re-enabled and addressed in the next release.
Update Gems and Address New Rubocop Offences
Resolves the following error: Invalid workflow file: .github/workflows/danger.yml#L1 (Line: 20, Col: 12): Unexpected value '' Commit 8b95198 should've removed this alongside the `ruby-version: ` code.
Fix danger.yml workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this PR: