Conversation
lixiaoyan
commented
Sep 21, 2026
lixiaoyan
commented
- Terminate generated JSON files while preserving existing formatting.
- Update checked-in data and the constraints adapter.
- Cover lockfile newline stability and immutable installs.
- Terminate generated JSON files while preserving existing formatting. - Update checked-in data and the constraints adapter. - Cover lockfile newline stability and immutable installs. Co-authored-by: Codex (GPT-6 Astra) <codex@openai.com>
馃懛 Deploy request for yarn-v6 pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Adds trailing newlines to generated JSON artifacts and lockfiles while preserving formatting and immutable-install stability.
Changes:
- Updated JSON serializers across Rust and JavaScript components.
- Refreshed generated data and lockfile contents.
- Added lockfile newline and immutable-install coverage.
| File | Description |
|---|---|
yarn.lock |
Adds final newline. |
tests/鈥媋cceptance-tests/鈥媝kg-tests-specs/鈥媠ources/鈥媍ommands/鈥媔nstall.test.ts |
Tests lockfile newline stability. |
scripts/鈥媔mport-artifacts.mjs |
Terminates generated artifact JSON. |
packages/鈥媧pm/鈥媠rc/鈥媝roject.rs |
Terminates serialized lockfiles. |
packages/鈥媧pm/鈥媠rc/鈥媗inker/鈥媝np.rs |
Terminates PnP data JSON. |
packages/鈥媧pm/鈥媠rc/鈥媍onstraints/鈥媍onstraints.tpl.js |
Terminates constraints output. |
packages/鈥媧pm/鈥媠rc/鈥媍ommands/鈥媍onstraints.rs |
Avoids duplicate output newlines. |
packages/鈥媧pm/鈥媠rc/鈥媌uiltins/鈥媙ode.rs |
Terminates generated manifests. |
packages/鈥媧pm/鈥媠rc/鈥媌uild.rs |
Terminates build state JSON. |
packages/鈥媧pm/鈥媎ata/鈥媌uiltin-extensions.json |
Updates generated data newline. |
packages/鈥媧pm-switch/鈥媠rc/鈥媗inks.rs |
Terminates switch configuration JSON. |
packages/鈥媧pm-switch/鈥媠rc/鈥媎aemons.rs |
Terminates daemon metadata JSON. |
packages/鈥媧pm-switch/鈥媠rc/鈥媍ache.rs |
Terminates cache metadata JSON. |
packages/鈥媧pm-constraints/鈥媔ndex.ts |
Terminates constraints result JSON. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.