fix: the code blocks sensitive credential options fr... in... - #26
Open
anupamme wants to merge 1 commit into
Open
fix: the code blocks sensitive credential options fr... in...#26anupamme wants to merge 1 commit into
anupamme wants to merge 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
skills/xmemo/scripts/xmemo-skill.mjs.Vulnerability
V-001skills/xmemo/scripts/xmemo-skill.mjs:386Description: The code blocks sensitive credential options from CLI flags, but the XMEMO_KEY environment variable can still be exposed through process listings, shell history files, or inline environment variable assignment. Additionally, the --allow-plaintext flag permits storing credentials in plaintext files at ~/.xmemo/skill-credentials.json.
Evidence
Exploitation scenario: An attacker with local system access can view process listings (ps aux) or shell history files to capture the XMEMO_KEY environment variable value if it's set in shell startup scripts or passed.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Threat Model Context
This is a Node.js library - vulnerabilities affect downstream consumers who use this package.
Changes
skills/xmemo/scripts/xmemo-skill.mjsBehavior Preservation
The change is scoped to 1 file on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.
Automated security fix by OrbisAI Security