feat: implement Application layer for adding favorites / お気に入り追加のApplication層実装 - #562
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/user-favorite #562 +/- ##
========================================================
+ Coverage 63.18% 63.28% +0.09%
- Complexity 1635 1640 +5
========================================================
Files 138 140 +2
Lines 8475 8497 +22
========================================================
+ Hits 5355 5377 +22
Misses 3120 3120
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / 目的
Following the Infra layer (#561), this PR implements the Application layer for the favorites feature: an
AddFavoriteUseCasethat lets a user add a world heritage site to their favorites viaFavoriteRepositoryInterface.No
UseCommandorDtois introduced here —handle()only needsuser_idandworld_heritage_id, and the operation returnsvoid, so passing primitives directly follows the existingDeleteUserUseCasepattern rather than adding an object wrapper for two scalar values.What I have done / 実施内容
AddFavoriteUseCase::handle(int $userId, int $worldHeritageSiteId): void, delegating toFavoriteRepositoryInterface::addFavorite()AddFavoriteUseCaseusing MockeryTest Results / テスト結果