Skip to content

test(cli): keep fixture host until released - #2304

Open
pcristin wants to merge 2 commits into
DeusData:mainfrom
pcristin:codex/fix-cli-fixture-lifetime
Open

pcristin wants to merge 2 commits into
DeusData:mainfrom
pcristin:codex/fix-cli-fixture-lifetime

Conversation

@pcristin

Copy link
Copy Markdown
Contributor

What does this PR do?

The CLI install test host had a fixed 120-second lifetime. On a slow machine, copying the large ASan test binary can take longer than that, so the host exits before the test probes it. The host already has a parent release pipe: this change waits for that release or an actual daemon exit.

The failure was exposed while validating #2265. On the unmodified issue branch, the affected CLI test failed three times. Baseline main passed the isolated test twice. With this fixture fix, the full CLI suite passed all 321 tests; a combined-tree scripts/test.sh run passed 8,177 tests, failed 0, and skipped 8 across 143 suites. That script then stopped at its watcher process guard because another CBM process was active on the machine, so its final exit status was nonzero.

Validation: clang-format-20 --dry-run --Werror and scripts/check-dco.sh HEAD^..HEAD passed. The full scripts/lint.sh --ci run did not finish within 45 minutes in cppcheck; changed production sources were checked separately with pinned cppcheck 2.20.0.

OpenAI Codex assisted with the investigation, implementation, testing, and PR preparation. Pcristin reviewed and certified the signed-off commit.

Checklist

  • DCO sign-off on every commit
  • Existing CLI regression test passes with this fix
  • Full test script completes locally (suite passed; later process guard encountered an active CBM process)
  • Full lint script completes locally (cppcheck exceeded 45 minutes)

Signed-off-by: Pcristin <xxxokzxxx@protonmail.com>
@pcristin
pcristin requested a review from DeusData as a code owner September 24, 2026 20:45
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant