Conversation
Signed-off-by: Pcristin <xxxokzxxx@protonmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The CLI install test host had a fixed 120-second lifetime. On a slow machine, copying the large ASan test binary can take longer than that, so the host exits before the test probes it. The host already has a parent release pipe: this change waits for that release or an actual daemon exit.
The failure was exposed while validating #2265. On the unmodified issue branch, the affected CLI test failed three times. Baseline
mainpassed the isolated test twice. With this fixture fix, the full CLI suite passed all 321 tests; a combined-treescripts/test.shrun passed 8,177 tests, failed 0, and skipped 8 across 143 suites. That script then stopped at its watcher process guard because another CBM process was active on the machine, so its final exit status was nonzero.Validation:
clang-format-20 --dry-run --Werrorandscripts/check-dco.sh HEAD^..HEADpassed. The fullscripts/lint.sh --cirun did not finish within 45 minutes in cppcheck; changed production sources were checked separately with pinned cppcheck 2.20.0.OpenAI Codex assisted with the investigation, implementation, testing, and PR preparation. Pcristin reviewed and certified the signed-off commit.
Checklist