Skip to content

test(cli): keep fixture host until released #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcristin wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

test(cli): keep fixture host until released #2304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f91a16
test(cli): keep fixture host until released
pcristin Sep 24, 2026
262d7ca
Merge branch 'main' into codex/fix-cli-fixture-lifetime
pcristin Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/test_cli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1653,8 +1653,9 @@ static _Noreturn void cli_scope_host_child(const cli_scope_fixture_t *fixture, i
(void)write(ready_fd, &ready, 1);
close(ready_fd);
bool drained = false;
uint64_t deadline = cbm_now_ms() + 120000U;
while (ready_ok && cbm_now_ms() < deadline) {
/* The parent owns the release pipe. If it exits, poll observes POLLHUP;
* a fixed lifetime can stop a healthy host during a slow binary install. */
while (ready_ok) {
if (cbm_daemon_runtime_service_wait_exited(service, 50U)) {
drained = true;
break;
Expand Down
Loading